git ssb


1+

ev / minbay



Since attempting to rush (despite all warnings) the flumeview branch into production I've discovered a new bug in @%minbay, while rolling out the new views.

%6YHmescNr5XVT4e7M/63gkbyleIcE7hZe2zbpd66Img=.sha256
Openev opened this issue on 7/4/2017, 12:14:00 AM

Since attempting to rush (despite all warnings) the flumeview branch into production I've discovered a new bug in @%minbay, while rolling out the new views.

Cannot read property 'version' of undefined
TypeError: Cannot read property 'version' of undefined
    at http://ssb.evbogue.com/:5872:40
    at http://ssb.evbogue.com/:6147:33
    at Object._requests.(anonymous function) (http://ssb.evbogue.com/:10376:5)
    at PacketStream._onrequest (http://ssb.evbogue.com/:10489:26)
    at PacketStream.write (http://ssb.evbogue.com/:10472:41)
    at http://ssb.evbogue.com/:9753:15
    at http://ssb.evbogue.com/:11233:37
    at http://ssb.evbogue.com/:11530:11
    at Object.cb (http://ssb.evbogue.com/:10315:11)
    at drain (http://ssb.evbogue.com/:12325:14)

I'm looking into what is causing this error.

%J3zb4LEnwdnNehkPVWRxksPiOrV+t/cbv1thj795vTQ=.sha256 ev · 7/4/2017, 2:56:16 PM

This error is breaking lite client invites in the flume branch of %minbase

versionofundefined.png

%ZpDl3OLH+Fy0K2tFGjYu45pTT7sceyzM3/yQcyB6GGg=.sha256 ev · 7/6/2017, 3:21:22 AM

I spent a little time messing around with trying to fix lite client invites in minbase#flume. I ended up getting this error which might be more useful:

Uncaught TypeError: Cannot read property 'seq' of null
    at http://127.0.0.1:3013/:5970:34
    at Object._requests.(anonymous function) (http://127.0.0.1:3013/:9989:5)
    at PacketStream._onrequest (http://127.0.0.1:3013/:10102:26)
    at PacketStream.write (http://127.0.0.1:3013/:10085:41)
    at http://127.0.0.1:3013/:9366:15
    at http://127.0.0.1:3013/:10846:37
    at http://127.0.0.1:3013/:11143:11
    at Object.cb (http://127.0.0.1:3013/:9928:11)
    at drain (http://127.0.0.1:3013/:11905:14)
    at more (http://127.0.0.1:3013/:11917:13)

I'm still not sure what is going on here and why lite client invites are broken with the introduction of flume in the client though. It seems to appear when the key in localStorage is different than the key on server hosting the invite.

%AwYIw3lc+uKIogt01rwAUbosCVSPcPLEDXmnACvBspk=.sha256 Dominic · 7/6/2017, 4:22:00 AM

I think if you build the bundled with browserify --debug you should get the proper line numbers, that will make this easier to figure out.

%g/oMKHRU1VWkneiEAUtGclKxHH3EfwwU5O7xvskt3oc=.sha256 ev · 7/6/2017, 2:02:26 PM

@dominic I ran browserify --debug, which gave me a little more info.

Cannot read property 'seq' of null
TypeError: Cannot read property 'seq' of null
    at file:///home/ev/minbase/build/index.html:5983:34
    at Object._requests.(anonymous function) (file:///home/ev/minbase/build/index.html:10009:5)
    at PacketStream._onrequest (file:///home/ev/minbase/build/index.html:10122:26)
    at PacketStream.write (file:///home/ev/minbase/build/index.html:10105:41)
    at file:///home/ev/minbase/build/index.html:9384:15
    at file:///home/ev/minbase/build/index.html:10868:37
    at file:///home/ev/minbase/build/index.html:11165:11
    at Object.cb (file:///home/ev/minbase/build/index.html:9947:11)
    at drain (file:///home/ev/minbase/build/index.html:11928:14)
    at more (file:///home/ev/minbase/build/index.html:11940:13)

The initial error seems to be coming from flumeview-reduce https://github.com/flumedb/flumeview-reduce/blob/7027fbd9d4798c454449865610e8fe94c9ef4589/store/remote.js#L21

minbase is building fine, this error only appears in the error tab inside @%minbase when the key in the localStorage.remote is different than the key on the server.

Maybe it's because we haven't yet built flumeviews for keys other than the one used by the remote scuttlebot instance? Or perhaps we need to generate new flumeviews for the key in localStorage.remote and load them into the browser?


Built with git-ssb-web